Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Editorial workflow #21

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Feature: Editorial workflow #21

merged 6 commits into from
Feb 8, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Jul 26, 2023 •
edited
Loading

https://decapcms.org/docs/configuration-options/#publish-mode
https://cms-demo.netlify.com/#/workflow

Turns on the editorial kanban, where you can review and promote PRs using a GUI.

Fixes #18

@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

✅ Deploy Preview for cyf-pd ready!

Name Link
🔨 Latest commit 15b2ebc
🔍 Latest deploy log https://app.netlify.com/sites/cyf-pd/deploys/65c4f4b3b920de00083c1676
😎 Deploy Preview https://deploy-preview-21--cyf-pd.netlify.app/admin
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

Comment has been resolved

Sally McGrath left a comment:

recording

Browser metadata 
Path:      /admin/#/workflow
Browser:   Chrome 114.0.0.0 on Mac OS 10.15.7
Viewport:  1508 x 865 @2x
Language:  en-GB
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

@SallyMcGrath
Copy link
Member Author

Reminding you about this, @kfklein15

@kfklein15
Copy link
Contributor

I believe @LaraHuzjan replied to you on this. But not 100% sure, so tagging her.

@SallyMcGrath
Copy link
Member Author

I believe @LaraHuzjan replied to you on this. But not 100% sure, so tagging her.

There's nothing on this PR from Lara

@kfklein15
Copy link
Contributor

Not on this PR, but I think she replied in other ways :) That's why I am tagging her so she can see it.

@LaraHuzjan
Copy link
Contributor

@SallyMcGrath @kfklein15
This is what I wrote:

Thank you for this Sally, just some comments for Karen and you to see:
-we still keep the Word document as it's easier to comment and imo is more clear
-the person that makes the content uploads the content (preferably in a week's time)
-can we omit the "draft" part and just have "in review" (once uploaded by the content creator it's already in review) and "ready" (once one of us has reviewed it and if necessary made any changes)

@SallyMcGrath
Copy link
Member Author

@SallyMcGrath @kfklein15 This is what I wrote:

Thank you for this Sally, just some comments for Karen and you to see: -we still keep the Word document as it's easier to comment and imo is more clear -the person that makes the content uploads the content (preferably in a week's time) -can we omit the "draft" part and just have "in review" (once uploaded by the content creator it's already in review) and "ready" (once one of us has reviewed it and if necessary made any changes)

Thanks Lara

Can I ask you to more clearly state what changes (if any) you require on this PR? There's no Word document here, for example.

@LaraHuzjan
Copy link
Contributor

@SallyMcGrath
First two are more meant for Karen, but the last comment is meant for this - https://cms-demo.netlify.com/#/workflow

@SallyMcGrath
Copy link
Member Author

This will likely stay blocked until someone spends some time understanding and explaining clearly exactly what they need.

@kfklein15 kfklein15 self-assigned this Dec 4, 2023
@kfklein15 kfklein15 removed their request for review December 5, 2023 09:33
@SallyMcGrath
Merge branch 'main' into feature/18-editor-workflow
0b40a7d
@SallyMcGrath
hide first column
0563f1d 
this workflow looks not very customisable from the docs
@SallyMcGrath
uncomfortably fragile tweak...
7fa3d67
@SallyMcGrath
improve selector to limit to workflow
d365d61
@SallyMcGrath
use universal
15b2ebc 
sorry -- there's no way to do this on local atm so it's a bit noisy pushing everything up
@SallyMcGrath SallyMcGrath merged commit c8a611a into main Feb 8, 2024
4 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/18-editor-workflow branch February 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kfklein15 kfklein15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Approval of content
3 participants
@SallyMcGrath @kfklein15 @LaraHuzjan